rand use getrandom for freebsd (available since 12.x) #107159

devnexen · 2023-01-21T17:11:34Z

No description provided.

rustbot · 2023-01-21T17:11:41Z

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-01-21T17:11:43Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Mark-Simulacrum · 2023-01-21T19:18:58Z

It seems like this should wait for #89058 to go through?

devnexen · 2023-01-21T20:29:44Z

indeed .. expecting all goes to plan🙂

Mark-Simulacrum · 2023-01-21T20:31:45Z

Okay, I'll mark as blocked for now. In general I'm not sure keeping this open ~indefinitely is helpful, at minimum please signal that it is in fact blocked when opening such PRs.

bors · 2023-07-26T21:39:41Z

☔ The latest upstream changes (presumably #114103) made this pull request unmergeable. Please resolve the merge conflicts.

workingjubilee · 2023-07-30T09:08:56Z

That FCP completed and was accepted, buuut PR now needs rebase.

@rustbot author

workingjubilee · 2023-10-10T00:15:18Z

ope!
looks good!
@bors r+

bors · 2023-10-10T00:15:20Z

📌 Commit 4b73cf3 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-10-10T03:13:25Z

⌛ Testing commit 4b73cf3 with merge 7d048ec...

…ngjubilee rand use getrandom for freebsd (available since 12.x)

rust-log-analyzer · 2023-10-10T04:07:36Z

The job i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests\ui\runtime\backtrace-debuginfo.rs stdout ----

error: test run failed!
status: exit code: 101
command: PATH="C:\a\rust\rust\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;C:\a\rust\rust\build\i686-pc-windows-gnu\stage0\bin;C:\a\rust\rust\ninja;C:\a\rust\rust\mingw32\bin;C:\hostedtoolcache\windows\Python\3.11.5\x64\Scripts;C:\hostedtoolcache\windows\Python\3.11.5\x64;C:\msys64\usr\bin;C:\a\rust\rust\sccache;C:\PROGRA~1\MongoDB\bin;C:\aliyun-cli;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\tools\zstd;C:\Program Files\Mercurial;C:\hostedtoolcache\windows\stack\2.11.1\x64;C:\cabal\bin;C:\ghcup\bin;C:\Program Files\dotnet;C:\mysql\bin;C:\Program Files\R\R-4.3.1\bin\x64;C:\SeleniumWebDrivers\GeckoDriver;C:\Program Files (x86)\sbt\bin;C:\Program Files (x86)\GitHub CLI;C:\Program Files\Git\bin;C:\Program Files (x86)\pipx_bin;C:\npm\prefix;C:\hostedtoolcache\windows\go\1.20.8\x64\bin;C:\hostedtoolcache\windows\Python\3.7.9\x64\Scripts;C:\hostedtoolcache\windows\Python\3.7.9\x64;C:\hostedtoolcache\windows\Ruby\2.5.9\x64\bin;C:\Program Files\OpenSSL\bin;C:\tools\kotlinc\bin;C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.382-5\x64\bin;C:\Program Files\ImageMagick-7.1.1-Q16-HDRI;C:\Program Files\Microsoft SDKs\Azure\CLI2\wbin;C:\ProgramData\kind;C:\Program Files\Eclipse Foundation\jdk-8.0.302.8-hotspot\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0;C:\Windows\System32\OpenSSH;C:\ProgramData\Chocolatey\bin;C:\Program Files\PowerShell\7;C:\Program Files\Microsoft\Web Platform Installer;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\160\DTS\Binn;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\ProgramData\chocolatey\lib\pulumi\tools\Pulumi\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\CMake\bin;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.8.7\bin;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\nodejs;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\Program Files\GitHub CLI;C:\tools\php;C:\Program Files (x86)\sbt\bin;C:\SeleniumWebDrivers\ChromeDriver;C:\SeleniumWebDrivers\EdgeDriver;C:\Program Files\Amazon\AWSCLIV2;C:\Program Files\Amazon\SessionManagerPlugin\bin;C:\Program Files\Amazon\AWSSAMCLI\bin;C:\Program Files (x86)\Google\Cloud SDK\google-cloud-sdk\bin;C:\Program Files (x86)\Microsoft BizTalk Server;C:\Program Files\LLVM\bin;C:\Users\runneradmin\.dotnet\tools;C:\Users\runneradmin\.cargo\bin;C:\Users\runneradmin\AppData\Local\Microsoft\WindowsApps" "C:\\a\\rust\\rust\\build\\i686-pc-windows-gnu\\test\\ui\\runtime\\backtrace-debuginfo\\a.exe"
---------------------------------------
trace does not match position list
trace does not match position list
still need to find ["backtrace-debuginfo.rs:184", "backtrace-debuginfo.rs:121"]
--- stdout
backtrace-debuginfo.rs:121
backtrace-debuginfo.rs:184

---
                       at /rustc/FAKE_PREFIX\library\std\src/panicking.rs:638:12
   9:   0xd40fd0 - <unknown>
  10:   0xa9794a - backtrace_debuginfo::main::h7f1d9bc6ac819adb
                       at C:\a\rust\rust\tests\ui\runtime\backtrace-debuginfo.rs:184:9
  11:   0xa842f9 - core::ops::function::FnOnce::call_once::hf285219168451d93
                       at /rustc/FAKE_PREFIX\library\core\src\ops/function.rs:250:5
  12:   0xa831d1 - std::sys_common::backtrace::__rust_begin_short_backtrace::hf088feb6ac2a8400
                       at /rustc/FAKE_PREFIX\library\std\src\sys_common/backtrace.rs:154:18
  13:   0xa83243 - std::rt::lang_start::{{closure}}::h55cced40e8edb133
                       at /rustc/FAKE_PREFIX\library\std\src/rt.rs:166:18
  14: 0x71618a0a - std::rt::lang_start_internal::ha57caf445342769f
  15:   0xa8321b - std::rt::lang_start::hd453c07e1bc8dce0
                       at /rustc/FAKE_PREFIX\library\std\src/rt.rs:165:17
  16:   0xa979ce - _main
  17:   0xa81386 - ___tmainCRTStartup
  19: 0x7775777d - <unknown>
  20: 0x7775774d - <unknown>
------------------------------------------
--- stderr -------------------------------

bors · 2023-10-10T04:08:01Z

💔 Test failed - checks-actions

ehuss · 2023-10-22T15:55:23Z

@bors r-

queue synchronize

ehuss · 2023-10-23T18:21:04Z

@bors r=workingjubilee

Re-adding to the queue, the previous error was due to a flaky test (#117097).

bors · 2023-10-23T18:21:06Z

📌 Commit 4b73cf3 has been approved by workingjubilee

It is now in the queue for this repository.

workingjubilee · 2023-10-23T20:11:09Z

Thanks for finding the flaky test!

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#107159 (rand use getrandom for freebsd (available since 12.x)) - rust-lang#116859 (Make `ty::print::Printer` take `&mut self` instead of `self`) - rust-lang#117046 (return unfixed len if pat has reported error) - rust-lang#117070 (rustdoc: wrap Type with Box instead of Generics) - rust-lang#117074 (Remove smir from triage and add me to stablemir) - rust-lang#117086 (Update .mailmap to promote my livename) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2023-10-23T22:43:44Z

Shouldn't this still be blocked on #89058?

Rollup merge of rust-lang#107159 - devnexen:random_fbsd_update, r=workingjubilee rand use getrandom for freebsd (available since 12.x)

rustbot assigned Mark-Simulacrum Jan 21, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 21, 2023

Mark-Simulacrum added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023

workingjubilee added the O-freebsd Operating system: FreeBSD label Feb 26, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Jul 30, 2023

devnexen force-pushed the random_fbsd_update branch from 82927a3 to c06ae45 Compare July 30, 2023 09:27

rand use getrandom for freebsd (available since 12.x)

4b73cf3

devnexen force-pushed the random_fbsd_update branch from c06ae45 to 4b73cf3 Compare July 30, 2023 09:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 10, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2023

Auto merge of rust-lang#107159 - devnexen:random_fbsd_update, r=worki…

7d048ec

…ngjubilee rand use getrandom for freebsd (available since 12.x)

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2023

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023

ehuss mentioned this pull request Oct 23, 2023

test ui/backtrace-debuginfo.rs is flaky #117097

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2023

matthiaskrgr mentioned this pull request Oct 23, 2023

Rollup of 6 pull requests #117103

Merged

bors merged commit d287861 into rust-lang:master Oct 24, 2023
11 of 12 checks passed

rustbot added this to the 1.75.0 milestone Oct 24, 2023

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2023

Unrolled build for rust-lang#107159

3106dcf

Rollup merge of rust-lang#107159 - devnexen:random_fbsd_update, r=workingjubilee rand use getrandom for freebsd (available since 12.x)

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

josephlr mentioned this pull request Apr 30, 2024

Remove fallback logic for FreeBSD rust-random/getrandom#412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rand use getrandom for freebsd (available since 12.x) #107159

rand use getrandom for freebsd (available since 12.x) #107159

devnexen commented Jan 21, 2023

rustbot commented Jan 21, 2023

rustbot commented Jan 21, 2023

Mark-Simulacrum commented Jan 21, 2023

devnexen commented Jan 21, 2023

Mark-Simulacrum commented Jan 21, 2023

bors commented Jul 26, 2023

workingjubilee commented Jul 30, 2023

workingjubilee commented Oct 10, 2023

bors commented Oct 10, 2023

bors commented Oct 10, 2023

rust-log-analyzer commented Oct 10, 2023

bors commented Oct 10, 2023

ehuss commented Oct 22, 2023

ehuss commented Oct 23, 2023

bors commented Oct 23, 2023

workingjubilee commented Oct 23, 2023

tgross35 commented Oct 23, 2023

rand use getrandom for freebsd (available since 12.x) #107159

rand use getrandom for freebsd (available since 12.x) #107159

Conversation

devnexen commented Jan 21, 2023

rustbot commented Jan 21, 2023

rustbot commented Jan 21, 2023

Mark-Simulacrum commented Jan 21, 2023

devnexen commented Jan 21, 2023

Mark-Simulacrum commented Jan 21, 2023

bors commented Jul 26, 2023

workingjubilee commented Jul 30, 2023

workingjubilee commented Oct 10, 2023

bors commented Oct 10, 2023

bors commented Oct 10, 2023

rust-log-analyzer commented Oct 10, 2023

bors commented Oct 10, 2023

ehuss commented Oct 22, 2023

ehuss commented Oct 23, 2023

bors commented Oct 23, 2023

workingjubilee commented Oct 23, 2023

tgross35 commented Oct 23, 2023